microsoft / knack

Knack - A Python command line interface framework
https://pypi.python.org/pypi/knack
MIT License
347 stars 95 forks source link

Mark Python 3.12 support #279

Closed tonybaloney closed 2 months ago

tonybaloney commented 11 months ago

I've run the tests locally and all pass

onlined commented 2 months ago

@jiasli @yonzhan @AllyW sorry for mentioning directly, but can someone review this? It's a simple and small PR.

jiasli commented 2 months ago

We will work on Python 3.12 support together with https://github.com/Azure/azure-cli/issues/27673.

onlined commented 2 months ago

I think this can be merged independently, I don't understand, are these projects coupled? Or don't you trust the tests enough that you can't merge before you run Azure CLI tests with Knack on Python 3.12?