The PyTorch example code passes the arguments to backward in the opposite order to that used in Knossos. I forgot to switch the arguments when changing the benchmark to use the Knossos wrapper.
I should have picked this up in manual testing, sorry. The bug is not found by CI because we have some benchmarks which are expected to give incorrect results (the embedded_INCORRECT benchmarks). Maybe we should disable those benchmarks in CI so that we can fail the build if another example breaks?
Fixes a bug in #1001.
The PyTorch example code passes the arguments to
backwardin the opposite order to that used in Knossos. I forgot to switch the arguments when changing the benchmark to use the Knossos wrapper.I should have picked this up in manual testing, sorry. The bug is not found by CI because we have some benchmarks which are expected to give incorrect results (the
embedded_INCORRECTbenchmarks). Maybe we should disable those benchmarks in CI so that we can fail the build if another example breaks?