search

microsoft / knossos-ksc

Compiler with automatic differentiation
Other
45 stars 10 forks source link

Remove infix pretty printer #1054

Closed toelli-msft closed 2 years ago

toelli-msft commented 2 years ago

Perhaps somewhat controversial, but we don't use the infix ks syntax except for occasional diagnostic messages. There's no parser for it. I think it's much less confusing to just maintain a single pretty printer.

(based on https://github.com/microsoft/knossos-ksc/pull/1053)

awf commented 2 years ago

Note that architecture.md is also part of the PR -- I'm fine with that, but it is somewhat orthogonal.

awf commented 2 years ago

https://msrcambridge.visualstudio.com/Knossos/_build/results?buildId=115475&view=logs&j=1287b841-589e-5c11-50b2-be5413241f28&t=d2fda8d9-b80e-5293-cba6-6530bd9ae26b&l=63

Hmm.. Nothing in this PR should cause this failure. I'll try a re-run, but that should /not/ work.

toelli-msft commented 2 years ago

Yeah I don't know what could cause that. Maybe PyPI has removed the old versions of jaxlib that it used to have?

ERROR: Could not find a version that satisfies the requirement jaxlib==0.1.41 (from versions: 0.1.60, 0.1.61, 0.1.62, 0.1.63, 0.1.64, 0.1.65, 0.1.66, 0.1.67, 0.1.68, 0.1.69, 0.1.70, 0.1.71)
ERROR: No matching distribution found for jaxlib==0.1.41
toelli-msft commented 2 years ago

It does look like 0.1.60 is the oldest available version

https://pypi.org/project/jaxlib/#history

toelli-msft commented 2 years ago

https://github.com/microsoft/knossos-ksc/pull/1055 might fix it

awf commented 2 years ago

Ah, or #1056 :) Let's see...