search

microsoft / knossos-ksc

Compiler with automatic differentiation
Other
45 stars 10 forks source link

Fix SUF defs for sin #861

Closed dcrc2 closed 3 years ago

dcrc2 commented 3 years ago

Fix sin, and add aten::cos.

Demonstrates that we need more testing - though this particular fix is tested as part of the sqrl example, after applying PR #855.

AB#19432

toelli-msft commented 3 years ago

Demonstrates that we need more testing

️🤦‍♂️ Yes, there have been a few of these recently, for example lt and pow.

Thank you for catching this.