cgravill
commented
3 years ago Look great!
(I don't actually have a clear idea of the knock on impacts of this change. I guess it just runs it in the benchmark workflow?)
To add a bit of context. This change means that the action, specifically https://github.com/microsoft/knossos-ksc/blob/1e546aa41ea0a9690ca255e6b6c7f65b0900784d/.github/workflows/benchmark.yml#L35
then
that's scheduled to run
will also include gelu.
There's a conditional in the action, so for the PR check the benchmark has already been run to completion and uploaded to the artifacts. In there you can see another file (the 0002 prefixed one) that contains the gelu results.
When it's run on the schedule against master, the results are uploaded on Azure and can be accessed here: https://github.com/microsoft/knossos-ksc/tree/1e546aa41ea0a9690ca255e6b6c7f65b0900784d/src/bench#getting-existing-results
This will all cause benchmarks to be collected. It won't yet be shown on any charts, that's a separate piece of work over here: AB#19590 which isn't scheduled yet.
As per AB#19578 (https://msrcambridge.visualstudio.com/Knossos/_boards/board/t/Knossos%20Team/Stories/?workitem=19578)
(I don't actually have a clear idea of the knock on impacts of this change. I guess it just runs it in the benchmark workflow?)
Output
(from the new part of the benchmark script)