microsoft / knossos-ksc

Compiler with automatic differentiation
Other
45 stars 10 forks source link

Remove Expr.__str__ dependency on prettyprint #926

Open awf opened 3 years ago

awf commented 3 years ago

After #917 , Expr and prettyprint have a circular dependency.

We should make str emit s-exps without that dependency.

This will duplicate some code from prettyprinter, but much of the time we can have prettyprinter call str.

acl33 commented 3 years ago

but much of the time we can have prettyprinter call str.

That's the part that we didn't achieve in the RLO Expression - but if we can, then sounds great :)