Make knossos.h compilable by nvcc

microsoft / knossos-ksc

Compiler with automatic differentiation

Other

45 stars 10 forks source link

Make knossos.h compilable by nvcc #978

Closed dcrc2 closed 2 years ago

dcrc2 commented 2 years ago

Attempting to compile code for the GPU revealed two problems with knossos.h:

Functions not declared as inline, causing ODR violations.
An issue with the metaprogramming used to generate the type Tuple<int, int, ...>. I'm not sure whether nvcc is correct in rejecting this, but anyway it can be worked around with a small rewrite of the code.

dcrc2 commented 2 years ago

Looks good. Would it be worth commenting either or both of these?

Right, yes, I've added a comment for the Int_t implementation. I think the inline issues were outright bugs. I've also added #pragma once to knossos-prelude.h as you suggested earlier.