search

microsoft / knossos-ksc

Compiler with automatic differentiation
Other
45 stars 10 forks source link

Don't pass make binds #983

Closed toelli-msft closed 3 years ago

toelli-msft commented 3 years ago

I was confused why make_binds and translate_node were inner functions, forcing make_binds to be passed manually to a couple of places. Could we make them methods instead?

cgravill commented 3 years ago

Looks good to me.

Historical context: there was more passing of functions. That's shifted over time and it's much clearer with your changes.