search

microsoft / krabsetw

KrabsETW provides a modern C++ wrapper and a .NET wrapper around the low-level ETW trace consumption functions.
Other
588 stars 147 forks source link

C++ 20 Support #165

Closed vpa1977 closed 3 years ago

vpa1977 commented 3 years ago

I have tried to compile krabsetw examples using `/std::c++latest' . Due to the change in widechar handling, the compilation produces following error:

Error   C2280   'std::basic_ostream<char,std::char_traits<char>> &std::operator <<<std::char_traits<char>>(std::basic_ostream<char,std::char_traits<char>> &,const wchar_t *)': attempting to reference a deleted function  NativeExamples  .\krabsetw\krabs\krabs\provider.hpp 539

Would It be possible to modify provider name logging to convert it from widechar to utf8 to support C++ 20 ?

swannman commented 3 years ago

Good catch @vpa1977! If you'd like to submit a PR to address this I'd be happy to review.

vpa1977 commented 3 years ago

Thanks !!! I've added https://github.com/microsoft/krabsetw/pull/166

swannman commented 3 years ago

Resolved by #166. Thanks @vpa1977!