microsoft / krabsetw

KrabsETW provides a modern C++ wrapper and a .NET wrapper around the low-level ETW trace consumption functions.
Other
581 stars 149 forks source link

add stack trace helpers (#26) #191

Closed jdu2600 closed 2 years ago

jdu2600 commented 2 years ago

I've added some helper functions for parsing stack traces from a record's extended data.

In particular, this exposes stack traces to C#.

jdu2600 commented 2 years ago

cc: @pathtofile

jdu2600 commented 2 years ago

🤔 The CI Build failure appears unrelated to this PR?

pathtofile commented 2 years ago

Awesome Idea! As for the CI break, it's because it's using windows-latest, which switched to only having Visual Studio 2022 on it. I fixed this with Sealighter's CI using the windows-2019 target: https://github.com/pathtofile/Sealighter/blob/main/.github/workflows/main.yml

Also see: https://github.com/actions/virtual-environments/issues/3949

jdu2600 commented 2 years ago

CI fixed. That was easy. 😁 I need to learn github workflows one day.

Hmm. So how do I credit you on this PR? I pretty much just wrapped the code you pasted in the ticket. 😃

swannman commented 2 years ago

@jdu2600 just a quick ping - minor code review feedback and then this is good to check in!

jdu2600 commented 2 years ago

Just back from vacation. 😄