search

microsoft / krabsetw

KrabsETW provides a modern C++ wrapper and a .NET wrapper around the low-level ETW trace consumption functions.
Other
589 stars 149 forks source link

Cosmetic fixes (wording, formatting) #86

Closed lupino3 closed 4 years ago

lupino3 commented 4 years ago

This changes improves the wording around the ETW interface (formerly nightmare.hpp), and improves the formatting for the compilation README.

I also added vim files to .gitignore mostly to make my own git output clean.

I verified locally all the unit tests with VS2017 and they all work except for when_int32_values_are_same_is_should_match, which fails also in the case of a clean HEAD checkout, so I don't think this pull request is responsible in any way for that failure. I tried briefly to debug it but failed, might try to do it when I get some free time.

lupino3 commented 4 years ago

@swannman please review this PR, I created it after our discussion yesterday. Thanks!

lupino3 commented 4 years ago

Thanks Matt! Could you please merge the PR?