microsoft / lamar-benchmark

Source code for the ECCV 2022 paper "Benchmarking Localization and Mapping for Augmented Reality".
Creative Commons Attribution 4.0 International
385 stars 36 forks source link

Load trace.csv, navvis artifact. #58

Closed pablospe closed 7 months ago

pablospe commented 9 months ago

From: https://knowledge.navvis.com/docs/mapping-path

For every dataset, the file trace.csv contains position, orientation, and magnetic field information in frequent intervals. Example:

#nsecs,  x, y, z,  ori_w, ori_x, ori_y, ori_z,  mag_x, mag_y, mag_z
1478254247676381327, 8.84298e-07, 1.28572e-06, -0.2, 0.999992, 0.000376351, 0.00401342, 1.90039e-07,  -6.51576e-07, -3.18442e-06, -3.36381e-05
1478254247783401487, 0.00150315, 0.000978242, -0.2, 0.999992, 0.000330729, 0.00398468, -6.80018e-05,  -1.30323e-06, -3.18672e-06, -3.33109e-05
pablospe commented 8 months ago

I fixed some issues with cam0 (upright problems and tile_id 0 is not actually identity, so I needed to apply this rotation only to the trace data, if I wanted to put in the same reference frame).

pablospe commented 7 months ago

This was merged without squash, I will revert and merged again to keep the git history short.

sarlinpe commented 7 months ago

Yes please! You could disable merge commits (I don't have permission to do so).

pablospe commented 7 months ago

The github button for reverting simply create a new PR reverting the changes, which won't remove the commits from history. I will have to probably do "hard reset" and then "force push" to remove from history from main. Any other alternative?

sarlinpe commented 7 months ago

You can squash the N commits introduced by the PR (with interactive rebase) and force push - you might need to temporarily disable the branch protection.

pablospe commented 7 months ago

Done.

Steps:

  1. # Remove the rules for the main protection (allowing temporally force pushes).
  2. git checkout main
  3. git merge --squash pablo/trace
  4. git commit -m "Load trace.csv, navvis artifact. (#58)"
  5. # Disable force push in main again.
pablospe commented 7 months ago

And final step, now we only "Allow squash merging".

image