Closed vjlux closed 3 months ago
How large is this test data? I would very much avoid committing it to the repo, which would force all users to download it even though it is used only for testing. Instead, 1) add it as a git submodule or 2) zip it, add it as release artefact, and download it when running the tests. I prefer option 2.
How large is this test data? I would very much avoid committing it to the repo, which would force all users to download it even though it is used only for testing. Instead, 1) add it as a git submodule or 2) zip it, add it as release artefact, and download it when running the tests. I prefer option 2.
yes we can do option 2 and add a comment if you want test
I would very much avoid committing it to the repo, which would force all users to download it even though it is used only for testing
I agree, I was also proposing the same here :)
Now my question is, will we anyways download all this data when we do git clone
(actually twice because it was in the other PR too). Is there a way to avoid this? I think @mihaidusmanu had this problem in the past. What did you do? Other than --depth 1
in main branch? Just curious, probably we would need to force push and rewrite the git history. Just raising the concern that not merging these commits is not enough to avoid downloading the data.
By default git clone
only clones the main branch, so it should not include any of these files - especially since the branch of this PR has now been deleted.
Add NavVis test files for testing.
test data restored from https://github.com/microsoft/scantools/tree/main/test_data