search

microsoft / landcover

Land Cover Mapping
201 stars 84 forks source link

Problem with Exporting Geotiff files when using ESRI maps #24

Closed yuantt83 closed 2 years ago

yuantt83 commented 3 years ago

Hi there, First, thank you for sharing this fantastic source code!

I have encountered one problem when experimenting with the ESRI maps. If I load the ESRI basemap as a datalayer (as included in the original datasets.json script), everything works fine except the final step of exporting the output. A error message of 'undefined' appears on the front-end when I click on the 'Download' button (see the screenshot). No error msg appears in the server.py though. Also no problem with 'Download' if I use any other formats of datasets (e.g, type = 'CUSTOM' or 'USA_LAYER' or 'CVPR Landcover Layer. Anyone knows how to resolve this ? Many thanks!

image

yuantt83 commented 3 years ago

I just noticed that the error was caused by the 'get_data_from_geometry' method not implemented in Basemap datalayer. It would be cool if this is implemented.

calebrob6 commented 3 years ago

Hi @yuantt83, you are correct -- the reason why I didn't implement get_data_from_geometry is that the areas that people try to download might be enormous. Perhaps we can implement this with an area check first?