search

microsoft / landcover

Land Cover Mapping
201 stars 84 forks source link

Fixed ESRI maps not exporting #27

Closed Will747 closed 2 years ago

Will747 commented 2 years ago

This PR fixes #24

Hi, as mentioned in the issue get_data_from_geometry was unimplemented so I implemented it based on the get_data_from_extent function and added an area restriction. Although I'm not sure if this would be best in the get_data_from_geometry function so it won't affect other DataLoaders and if 10km^2 is about the right max size.

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

calebrob6 commented 2 years ago

Have you tested this locally?

Will747 commented 2 years ago

Yes, both with more then 10km^2 and the ones lower successfully loaded. Screenshot 2022-06-09 183321

calebrob6 commented 2 years ago

Cool! Thanks for the contribution :)

Will747 commented 2 years ago

No problem, happy to of contributed