search

microsoft / language-server-protocol

Defines a common protocol for language servers.
https://microsoft.github.io/language-server-protocol/
Creative Commons Attribution 4.0 International
10.95k stars 766 forks source link

Corrected names and registrationOptions for notebookDocument/sync notifications #1849

Closed 0xJonas closed 7 months ago

0xJonas commented 7 months ago

NotebookDocumentSyncOptions and NotebookDocumentSyncRegistrationOptions were referred to incorrectly in a few places. The meta model was also missing registrationOptions for the notebookDocument/sync notifications.

0xJonas commented 7 months ago

@microsoft-github-policy-service agree

dbaeumer commented 7 months ago

@0xJonas thanks for the PR. Could you please remove the changes to the metaModel.json. That file is auto generated and maintained here: https://github.com/Microsoft/vscode-languageserver-node. Thanks

dbaeumer commented 7 months ago

For the meta model see: https://github.com/microsoft/vscode-languageserver-node/pull/1369

0xJonas commented 7 months ago

The changes in the metaModel.json files have been reverted.