search

microsoft / language-server-protocol

Defines a common protocol for language servers.
https://microsoft.github.io/language-server-protocol/
Creative Commons Attribution 4.0 International
10.95k stars 766 forks source link

MetaModel: Missing Types and `TraceValue` vs `TraceValues` #1861

Closed yxrkt closed 7 months ago

yxrkt commented 7 months ago

Message, MessageDirection, NotificationMessage, RequestMessage, ResponseMessage, and ResponseError are missing from metaModel.json.

Also a very minor discrepancy: In the spec, it is called TraceValue. In metaModel.json, it is called TraceValues.

dbaeumer commented 7 months ago

The tyes are not in the meta model since they are concepts that come from JSON-RPC and might differ depending on the JSON RPC library you are using.

I did fix the TraceValue problem.

yxrkt commented 7 months ago

I just noticed URI and DocumentUri are missing. I suspect these aren't part of JSON-RPC?