search

microsoft / lida

Automatic Generation of Visualizations and Infographics using Large Language Models
https://microsoft.github.io/lida/
MIT License
2.6k stars 266 forks source link

Update notebook tutorial #49

Closed marco-ramirezpp closed 9 months ago

marco-ramirezpp commented 9 months ago

This change updates how the tutorial works.

marco-ramirezpp commented 9 months ago

@microsoft-github-policy-service agree

victordibia commented 9 months ago

Hi @marco-ramirezpp ,

Thanks for starting this PR. Can you outline the changes made here and some reasons for the changes compared to the current content of the notebook.

Thanks

marco-ramirezpp commented 9 months ago

Of course, @victordibia

In the previous Notebook the generation of visualizations via query was broken. This pull request updates this section.

Modifying the way of generation by including the query inside the Goal class.

victordibia commented 9 months ago

Ah. Thanks. Got it.

The Goal issue that this addresses was because of differences between the compiled version of lida vs source (which has a check that converts string goals to a correct goal object in the lida.visualize manager method). I mentioned that in this comment. These two versions are now in sync, so the goal query is no longer broken.

I think we can close this for now.

Thanks again for helping point this out, the feedback was definitely useful!

There are a few PRs where help is much appreciated!