microsoft / lida

Automatic Generation of Visualizations and Infographics using Large Language Models
https://microsoft.github.io/lida/
MIT License
2.71k stars 290 forks source link

feat: add a chart util for display ChartExecutorResponse #54

Closed bx-h closed 11 months ago

bx-h commented 11 months ago

52

bx-h commented 11 months ago

@microsoft-github-policy-service agree

victordibia commented 11 months ago

Hi @bx-h ,

Thanks for this, it makes a bit of progress in addressing #52. I was thinking of a much simpler solution ie. extending ChartExecutor response directly. I pushed that change. Main approach

Finally, I think displaying the image should be implemented outside the library, as many applications may chose to visualization an image in different ways.

In terms of your PR, while change e428 covers a bit of it, I think extending the tests you added would be valuable here

bx-h commented 11 months ago

Hi @victordibia , You're right! I've updated the test cases following your suggestion.