search

microsoft / lis-test

Contains test infrastructure for testing Linux virtual machines on Windows Azure and Hyper-V.
32 stars 72 forks source link

eventid_18602_regression.ps1: output fixes #1136

Closed lixuemin2016 closed 5 years ago

lixuemin2016 commented 5 years ago

Hi Chris, Looks that before original MultipleReboot.ps1 has been removed and replaced as eventid_18602_regression, running list in the fvt.xml files use MultipleReboot.ps1. So change back and refine some log output.

Thank you so much.

chvalean commented 5 years ago

Hi @lixuemin2016 . Based on previous test data the conclusion was that the original multiple reboot test was not catching boot failures, even if any, so we decided to replace it with a newer situation based on the mentioned commit ID. If for some reasons you still want to use the previous MultipleReboot test, can you please make that as a separate test case in the xml? That way you can still use it as fit, the code was already there.

Thank you!

lixuemin2016 commented 5 years ago

Hi Chris, yes, file eventid_18602_regression is very good to detect reboot failure, I do not want to use previous MultipleReboot test.

Two reasons about this change: 1) Original MultipleReboot.py has been removed based on PR https://github.com/LIS/lis-test/commit/fdc9b655cdfcfab8991c8d41056c4f039d8833ed#diff-7cc5af26bdc6fe093b7bf5ad19c10634, notice that hyperv_fvt.xml, kernel_pipeline_fvt.xml,lis_pipeline_fvt,ubuntu_azure_kernel_fvt.xml still use MultipleReboot.py but not eventid_18602_regression.py except EventID_18602_regression test case in StressTests.xml. 2) eventid_18602_regression is mainly used to test reboot vm, maybe file name "MultipleReboot.py" is more easy to indicate the main test points? Thank you so much.

lixuemin2016 commented 5 years ago

If you want to keep using the eventid_18602_regression as name, I can change it back. Thank you.

chvalean commented 5 years ago

Please keep the code changes in the script, but leave the naming as is. The referenced xml files do indeed carry the old test definition, however we actually do not run it - it's not in the list of tests, mainly due to the long time required for the test, so we keep it separate in the stress xml.

lixuemin2016 commented 5 years ago

Done. Thank you.