search

microsoft / live-share

Real-time collaborative development from the comfort of your favorite tools
http://aka.ms/vsls
Creative Commons Attribution 4.0 International
2.27k stars 248 forks source link

Sign in using GitHub Enterprise or ADFS Account #341

Closed MichaelAndCara closed 1 year ago

MichaelAndCara commented 6 years ago

Request

Not sure if it's already in the works, but will it be possible to sign in using a GitHub enterprise account, which is wired to our AD credentials?

Product and Version [VS/VSCode]: VSCode 1.22.2 OS Version [macOS/Windows]: Windows 10 Live Share Extension Version: 0.3.93 Target Platform or Language [e.g. Node.js]: any

Steps to Reproduce / Scenario:

  1. Sign In
  2. Choose github
Chuxel commented 6 years ago

@MichaelAndCara Thanks for asking. If your organization uses Azure AD, you can sign into that account using the "Microsoft" path. We support AAD and personal Microsoft accounts. However, we do not support on-prem ADFS or on-prem GitHub. Does that meet your need?

MichaelAndCara commented 6 years ago

Our organization does not use AADs, but Devs do have Microsoft accounts, which we can use.

However, our employees in our IT department are guaranteed to have a "normal" AD account. I figured if we were mentoring anyone (employees interested in becoming developers, interns, etc), it would be convenient to use our GitHub enterprise account that is tied to our "normal" AD accounts.

Thanks @Chuxel

Chuxel commented 6 years ago

@MichaelAndCara Got it. I'll flip this to a feature request given it sounds like in an ideal world you'd be able to use on-prem AD.

HenryHW commented 5 years ago

Really need the on-prem AD feature. Most of the environments I work in don't allow any Azure access. All Azure access is done on a separate network.

spkane commented 5 years ago

Github Enterprise support would be great.

peteashworth commented 5 years ago

We would love to use this in our organization but require github enterprise support.

lostintangent commented 5 years ago

@spkane @AshworthHub Out of curiosity: would on-prem AD support address your needs? Or would you specifically need GitHub Enterprise authentication?

peteashworth commented 5 years ago

@lostintangent we would need github enterprise.

spkane commented 5 years ago

@lostintangent Github Enterprise support. We are not a Windows shop, so AD support would not help us, but we do use GHE internally.

I would not expect this to be difficult, since as far as I know, it has all the same APIs. They usually just have a different base URL.

mezafits commented 5 years ago

This would be nice to have as an on prem solution, perhaps TFS integration?

legomushroom commented 5 years ago

cc @avanderhoorn

Garen commented 5 years ago

Suggest splitting this into two issues - I'm only interested in local AD support. (Some Github Enterprise users use it with AD, others don't).

CalPolyRock commented 5 years ago

Agree simple ad/ldap is all we need too. We'll never do github enterprise since we have on prem Atlassian stack.

Arshia001 commented 5 years ago

Also need this.

louisfischer commented 5 years ago

Need this also

MichaelSteinecke commented 5 years ago

In our company, we're developing in an completely disconnected environment with On Premise TFS and On Premise AD. So, on-prem ADFS is a must.

RobFur commented 5 years ago

We are also developing in a completely disconnected environment and on-prem ADFS is also a must for us.

zhaoshouren commented 5 years ago

would be interested in an on premise solution for organizations with restricted external network access.

allendcr commented 5 years ago

One more for "totally disconnected environment" - LiveShare would be huge for us but t's currently DOA

BenBurge commented 4 years ago

This feature for Live Share will be used by a lot of DoD contractors and government. Many times we are on offline networks for security reasons. The market for On-Premise is very large with governments.

maximedasilva commented 4 years ago

Hi, Does anyone have an update on this issue ? With the covid-19 out there, it would be very interesting for us to collaborate with this tool ! Thanks !

NicolasVargas commented 4 years ago

Sure ! I'm working in a company relied to the french ministry of labour and, of course, we rely on ADFS Accounts. Live Share would be a really nice tool to use ! Thanks

viralatron commented 4 years ago

Same here, due to privacy and security reasons we can't use GHE, regular Github os Azure AD.

JamesCatt commented 4 years ago

Also could really use this due to CoVID-19. Can't use without either Github Enterprise or on-premise AD.

tebeco commented 4 years ago

this would be great indeed, even if it means "only direct mode"

malghabr commented 4 years ago

Support, an on premise solution with AD would greatly be appreciated.

dankelley2 commented 4 years ago

+1 for an on-prem solution. Our windows based Dev team would love to use this but cannot have offsite authentication.

rpetersen3 commented 4 years ago

If we could restrict live-share to our O365 tenant or our github enterprise oauth it would be a huge win for our developers working from home. With COVID-19 and our working from home situation this enhancement cannot come fast enough!

lostintangent commented 4 years ago

@rpetersen3 If you were able to use the existing Azure Active Directory-based auth, and just needed a way to restrict collaboration to members of your tenant, you could take a look at using this extension and see if it meets your needs in the near-term? That handles automatically blocking guests that are external to the host’s domain.

rpetersen3 commented 4 years ago

Thanks, we will give it a try!

On Mon, May 18, 2020 at 10:09 AM Jonathan Carter notifications@github.com wrote:

@rpetersen3 https://github.com/rpetersen3 If you were able to use the existing Azure Active Directory-based auth, and just needed a way to restrict collaboration to members of your tenant, you could take a look at using this extension https://marketplace.visualstudio.com/items?itemName=vsls-contrib.gatekeeper and see if meets your needs in the near-term? That handles automatically blocking guests that are external to the host’s domain.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MicrosoftDocs/live-share/issues/341#issuecomment-630207234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHG63PKAF3AHO743KXZMMVLRSE6RRANCNFSM4E7C7JZQ .

mmodrow commented 3 years ago

I'm also in an environment, where MS-Logins are a no-go and we use on-prem AD with on-prem Azure Devops. Given this pandemic it would be hugely appreciated to use VS-Code+LiveShare through on-prem-means instead of sharing full screens behind a remote desktop through a VPN.

lateo-net commented 3 years ago

One more asking for a "local AD/LDAP login" feature suitable for isolated networks. Help us bring some fresh stuff in those forever-away-from-internet-networks. A hacky way is an okay way.

tstordyallison commented 3 years ago

Another +1 looking for an on-prem offering.

Support for ADFS/local AD and the option to run the ‘session discovery’ aspect of Live Shame on-prem, like TFS would be killer.

neufeind commented 3 years ago

Would authentication against some other servers/services be possible? For example one company uses their own Gitlab-setup (reachable from the internet) and also a nextcloud-installation to share with others. Both already contain user-accounts for the developers. Maybe authenticating by oauth against a configurable server would be possible or so?

JoaBjo commented 3 years ago

Support for on-prem AD is a must have feature!

cuongloveyou commented 3 years ago

image I can't using Github with Organizations. Read org and team membership, read org projects not found

GeorgeWL commented 2 years ago

seems weird that this ticket has been around for so long, it's not that complicated is it?

dnyazali commented 2 years ago

Could anyone share the latest status on this?

mmodrow commented 2 years ago

Could anyone share the latest status on this?

Looks to me like Microsoft is pretty busy ignoring this request to pressure everyone off on-premise solution.

lalten commented 2 years ago

@Chuxel @lostintangent @avanderhoorn is this on any roadmap? I would really love GitHub Enterprise auth.

jspada200 commented 2 years ago

Echoing what everyone else is saying. We could really use this but are air gapped so we are unable to meet the microsoft login requirements. Really need another solution for authentication.

adamdost-0 commented 2 years ago

Any updates on this?

matheuskknd commented 2 years ago

I'm also interested in this feature. A simple "IP+port" connection option would be enough for now, as we could set up a secure tunnel through many other ways (with any possible authentication method).

GeorgeWL commented 2 years ago

I know it must be possible, as the Github Pull Requests extension, can do it fine

samibrahmi commented 2 years ago

In our company, we're on a disconnected environment with an On Premise AD so I think on-prem ADFS will be a must.

cadeff01 commented 2 years ago

Disconnected or public sector azure gov both need this feature. Please implement.

GeorgeWL commented 2 years ago

👍

rmace001 commented 2 years ago

👍

jnorto1986 commented 2 years ago

Does anyone know if ADFS support has been added yet? Or if support for Gov cloud has been added?

1oakao1 commented 2 years ago

I am echoing what everyone else is saying. We could really use this but we are air-gapped so we are unable to meet the Microsoft login requirements. We really need another solution for authentication.