search

microsoft / live-share

Real-time collaborative development from the comfort of your favorite tools
http://aka.ms/vsls
Creative Commons Attribution 4.0 International
2.27k stars 248 forks source link

Liveshare logs are massive and took a long time to generate #3516

Closed connor4312 closed 4 years ago

connor4312 commented 4 years ago

Describe what happened: Exporting logs took about 15 minutes and created a 1.8 GB zip file

What was your system configuration? Product and Version [VS/VSCode]: VS Code, 1.46.0-insider 2020-05-11T10:00:12.459Z OS Version[macOS/Windows]: Windows_NT x64 10.0.18363 Live Share Extension Version: v1.0.2106 Target Platform or Language [e.g. Node.js]: N/A

Steps to Reproduce / Scenario:

  1. Start a live share session. I started debugging a "hello world" node.js process with our new debugger https://github.com/MicrosoftDocs/live-share/issues/3515
  2. Run the "Export logs" command
  3. The extension host took about 15 minute with very high disk read usage
  4. It eventually produced a 1.8GB zip file--I guess, after seeing CPU usage and i/o drop back down. While VS Code was open, it held onto it (reported by Unlocker) and I could not open the folder. After closing VS Code. Windows reported it as corrupt. 7zip was able to open it, but could not extract the log file (and honestly not sure I have enough disk space to decompress whatever 1.8GB of text represents!)

Please attach logs to this issue:

I can upload the corrupt zip somewhat on request.

Screenshots

The disk i/o was almost all reads:

Looks like a whole lot of filesystem reads, profile: https://memes.peet.io/img/CPU-20200511T174437.212Z.cpuprofile

Windows reports it as corrupt:

7zip gave more info:

IlyaBiryukov commented 4 years ago

Hi, Thanks for reporting this issue! Most likely the logs are polluted with some repeating message. If you can pick inside and what that message is, and the context when it starts repeating, we'd appreciate it.

connor4312 commented 4 years ago

Here you go: https://dankmemes.blob.core.windows.net/img/liveshare-logs.zip

IlyaBiryukov commented 4 years ago

The zip file is corrupt, I cannot open it. If you open %TEMP%\VSFeedbackVSRTCLogs folder, you can see the actual log files there. These are text files.

connor4312 commented 4 years ago

Yea, the generated file is corrupt. Unfortunately it looks like the logs have rotated since I initially reported the issue so I don't know what the original looked like.

IlyaBiryukov commented 4 years ago

I'm going to close the issue for now. If you see it again, please re-activate or submit a new one. Thanks!

connor4312 commented 4 years ago

This is happening for me again today. The liveshare log folder is rather large

Here's one of the smaller files -- 550 MB: https://memes.peet.io/img/20200604_181255_Agent.zip. The largest individual file is 3GB. Interestingly the mtime of these files is from today, although I haven't used liveshare in a couple weeks.

(Also -- I'm a MSFT'er, but there might be people who are suspicious about why liveshare is collecting so much information when it's not in use 🙂 )