search

microsoft / live-share

Real-time collaborative development from the comfort of your favorite tools
http://aka.ms/vsls
Creative Commons Attribution 4.0 International
2.28k stars 253 forks source link

[VS Code] DeprecationWarning: Buffer() is deprecated due to security and usability issues #5024

Open mburnell opened 9 months ago

mburnell commented 9 months ago

I know this issue has been reported multiple times in the past, but the older issues are all closed and it's still reproducible in 1.0.5905.

When running the following code from within a VS Code extension while the Live Share VS Code extension is installed and enabled:

const vsls = require('vsls');
const liveShare = vsls.getApi(); // await deliberately omitted, but not relevant

an error will be reported in the VS Code Developer Tools.

I've followed the steps at https://github.com/MicrosoftDocs/live-share/issues/3331#issuecomment-967229939 and the stack shows the issues are from .vscode-insiders/extensions/ms-vsliveshare.vsliveshare-1.0.5905/extension.js. Opening this file up, there are 31 usages of "new Buffer(".