search

microsoft / live-share

Real-time collaborative development from the comfort of your favorite tools
http://aka.ms/vsls
Creative Commons Attribution 4.0 International
2.27k stars 248 forks source link

Live share should not leave any source code after collabation end #605

Closed anthonyhorne closed 5 years ago

anthonyhorne commented 6 years ago

Product and Version [VS]: VS 15.7.4+27703.2035 OS Version [Windows]: Windows Live Share Extension Version: 0.3.319.38255 Target Platform or Language [e.g. ]: C#

Steps to Reproduce / Scenario:

  1. Open Collab session.
  2. Edit source file

Going to {AppData}\Temp{3}{Guid}, you will find the source code still there after session has ended. Organiser (sharer) should be given option to delete source code afterwards. Especially important if the recipient is on a beach holiday using shared internet with VS Code :)

lostintangent commented 6 years ago

@anthonyhorne Thanks for reaching out! This behavior is currently due to a limitation in VS (if you join a Live Share session from VS Code, nothing is written to disk), and only files that you actually open will be cached locally. That said, as you suggested, we intend to clear these temp files after the guest leaves the collaboration, so we’ll use this issue to track that work. Thanks!

daytonellwanger commented 5 years ago

@anthonyhorne are you still experiencing this behavior on the latest version of the extension?

anthonyhorne commented 5 years ago

Hi,

I have not used live share since the test. I generally install a new dev machine periodically to ensure I maintain latest setup and no invalid traces.

Regards, Anthony

From: Dayton Ellwanger notifications@github.com Sent: Monday, April 8, 2019 11:52 PM To: MicrosoftDocs/live-share live-share@noreply.github.com Cc: anthonyhorne anthonyhorne@live.co.za; Mention mention@noreply.github.com Subject: Re: [MicrosoftDocs/live-share] Live share should not leave any source code after collabation end (#605)

@anthonyhornehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fanthonyhorne&data=02%7C01%7C%7Caa2b7be038604956040908d6bc6c70a3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636903571255806136&sdata=jWlpn7cHONVNS7D89rpCaecavBY7WX%2BzVdpnWhl0t7c%3D&reserved=0 are you still experiencing this behavior on the latest version of the extension?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Flive-share%2Fissues%2F605%23issuecomment-481022052&data=02%7C01%7C%7Caa2b7be038604956040908d6bc6c70a3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636903571255816145&sdata=LkwQopTDwO%2B8CnXrmLi51Wyeoe%2FwNQ66oGZjKaTvEQE%3D&reserved=0, or mute the threadhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQEqYhAwrmkX555GAva9lwQJi9rt96Dfks5ve7oBgaJpZM4U0v9h&data=02%7C01%7C%7Caa2b7be038604956040908d6bc6c70a3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636903571255826153&sdata=msdqPrJ8rntTaJrjFWUaQms81k%2Bsv%2BUOtY%2FYmBCCRWc%3D&reserved=0.

daytonellwanger commented 5 years ago

Hey @anthonyhorne , we believe we've resolved this issue. If you find otherwise, please reopen. Thanks!