Add comments to parser.rs

v-jkegler commented 3 weeks ago

mmoskal commented 3 weeks ago

I did a small fix - new_row() is empty

v-jkegler commented 3 weeks ago

Good you caught this. And it makes sense that the code should work that way. Thanks!

From: Michał Moskal @.> Sent: Thursday, September 26, 2024 11:34 AM To: microsoft/llguidance @.> Cc: Jeffrey Kegler (Muse and Gordon Consulting PLLC) @.>; Author @.> Subject: Re: [microsoft/llguidance] Add comments to parser.rs (PR #18)

@mmoskal commented on this pull request.

In parser/src/earley/parser.rshttps://github.com/microsoft/llguidance/pull/18#discussion_r1777329984:

@@ -246,11 +246,14 @@ impl Scratch { } }

// Set current working Earley set to the single item

⬇️ Suggested change

// Set current working Earley set to the single item
// Set current working Earley to empty set

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/llguidance/pull/18#pullrequestreview-2331679942, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BLFFSVVDDPGUBC77SAL3UFTZYQSRRAVCNFSM6AAAAABO3Z2TWCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZRGY3TSOJUGI. You are receiving this because you authored the thread.Message ID: @.***>

microsoft / llguidance

Add comments to parser.rs #18