search

microsoft / lsif-node

Define an index format for Language Servers
MIT License
172 stars 37 forks source link

Upgrade version of lsif-util #115

Closed CsCherrYY closed 2 years ago

CsCherrYY commented 4 years ago

It seems that the current version of lsif-util uses version 0.4.3 of lsif-protocol as its dependency. It can't recognize some new features in LSIF version 0.5.0 such as attach edge of moniker. I would like to know if there is any plan of this tool to support LSIF version 0.5.0^.

dbaeumer commented 4 years ago

@jumattos would you be interested in looking into this?

jumattos commented 4 years ago

To answer @CsCherrYY's question, I had no plans of upgrading lsif-util. I haven't worked with LSIF for a while so I wasn't aware that version 0.5.0 was out. I am not familiar with the changes introduced by it.

It would be ideal for the tool to validate multiple versions to help developers upgrade their LSIF producers. Although I have no work capacity to do this, I'd be happy to review any PRs that tackle it; feel free to tag me.

dbaeumer commented 2 years ago

I started to write a full validator for the spec. It is avaibale as lsif validate. I will remove the lsif-util soon unless I find someone who wants to maintain the visualizer.

jumattos commented 2 years ago

@dbaeumer Understood! I am happy to hear that the idea of providing validation still lives on! Thank you for letting me know, I agree with you.