microsoft / lsif-node

Define an index format for Language Servers
MIT License
172 stars 37 forks source link

Fix free range validation for delayed `contains` nodes. #146

Closed NTaylorMullen closed 2 years ago

NTaylorMullen commented 2 years ago
dbaeumer commented 2 years ago

I think this validates the last constraint documented here: https://microsoft.github.io/language-server-protocol/specifications/lsif/0.6.0/specification/#emittingConstraints

This constraint got added on special request of the CodeIndex team :-). So we need to check if this can really be loosened.

NTaylorMullen commented 2 years ago

Talked offline: Looks like this is an intended restriction with the intention to ease LSIF consumption of tools like CodeIndex. Meaning, once an item element is parsed you're guaranteed to know what document that item belongs to so you don't need to keep as much in memory.

NTaylorMullen commented 2 years ago

Will close that out with this restriction /cc @jasonmalinowski