search

microsoft / lsprotocol

Code generator and generated types for Language Server Protocol.
MIT License
113 stars 21 forks source link

Publish new version with support for LSP 3.18 #369

Closed rowillia closed 2 weeks ago

rowillia commented 1 month ago

Hi all,

Do mind publishing a new release to pypi w/ support for LSP 3.18? I see you recently updated main for 3.18 and I'd love to try some of the new features like SnippetTextEdit.

Thanks!

karthiknadig commented 1 month ago

Yes we will publish soon. Doing some internal testing.

rowillia commented 1 month ago

Great to hear @karthiknadig !

When trying to move to migrate pygls to the latest version I noticed there have been a lot of breakages since the package was last published (e.g. WorkspaceConfigurationParams => ConfigurationParams, TraceValues => TraceValue, TextDocumentContentChangeEvent_Type1 => TextDocumentContentChangePartial).

Is there way to have a compatibility shim to make the update easier? Are the set of changes documented anywhere?

Since pygls depends on the lsprotocol types this would also require changes to all existing extensions (several of which were written by Microsoft)

karthiknadig commented 2 weeks ago

Published a pre-release version with new LSP 3.18. I also updated pygls see here: https://github.com/openlawlibrary/pygls/pull/487

They are both pinned to specific versions, and I plan to update Microsoft extensions to use the new pygls once it has a stable release.