search

microsoft / lst-bench

LST-Bench is a framework that allows users to run benchmarks specifically designed for evaluating Log-Structured Tables (LSTs) such as Delta Lake, Apache Hudi, and Apache Iceberg.
Apache License 2.0
62 stars 34 forks source link

Augment JDBC connection to log warnings associated with statement. #224

Closed anjagruenheid closed 7 months ago

anjagruenheid commented 7 months ago

Useful for SQL Server to grab distributed statement ids.

jcamachor commented 7 months ago

@netonjm, I think that is a good idea, but I'd handle it slightly differently than it is done in the current PR. Specifically, I propose introducing a property named 'verbose' (or a similar name) that can be optionally specified for each connection in the connections config file. If the value is set to true, warnings will be printed; otherwise, they will be ignored. This approach allows us to avoid introducing unnecessary latency in cases where we don't consider warnings critical as well. (Existing error handling logic probably does not need to be modified.) @anjagruenheid , thoughts?

anjagruenheid commented 7 months ago

I agree with @jcamachor. Added a parameter in the connection config to enable verbose logging of statement information, it is disabled by default so you would have to adjust that in any existing configurations but it should be backwards compatible. Let me know what you think!

netonjm commented 7 months ago

I agree with @jcamachor. Added a parameter in the connection config to enable verbose logging of statement information, it is disabled by default so you would have to adjust that in any existing configurations but it should be backwards compatible. Let me know what you think!

I agree, verbose sounds a perfect solution for that.