black is defined wrong in exporter colors

microsoft / maker.js

📐⚙ 2D vector line drawing and shape modeling for CNC and laser cutters.

http://maker.js.org

Apache License 2.0

1.76k stars 265 forks source link

black is defined wrong in exporter colors #433

Open DerKorb opened 5 years ago

DerKorb commented 5 years ago

When exporting dxf, the default color is black and is defined as 0 in core/exporter.ts 0 is an invalid value for autocad and it will fail to open the file for it. The right black value is 255.

danmarshall commented 5 years ago

Would you mind creating a PR with this change? Also, helps to add a link to documentation in the code :)