search

microsoft / maker.js

📐⚙ 2D vector line drawing and shape modeling for CNC and laser cutters.
http://maker.js.org
Apache License 2.0
1.76k stars 269 forks source link

Fix degenerate arc issue #575

Closed eflynch closed 11 months ago

eflynch commented 11 months ago

@microsoft-github-policy-service agree

eflynch commented 11 months ago

I checked locally that the unit test fails without the bug fix code change, so it is successfully testing the issue

danmarshall commented 11 months ago

Thanks for the contribution! I'm wondering if we should put the guard on the svg import code. 🤔

eflynch commented 11 months ago

I’m not sure quite what you mean, but if it’s helpful for evaluating what to do here, the reason I needed this change is because I need to round trip a makerjs model through an svg path, and depending on the exact situation, makerjs produces a model that holds these degenerate arcs which it was exporting successfully and then failing on import.

danmarshall commented 11 months ago

I see. If possible, a repro of that degeneration might be helpful.

danmarshall commented 11 months ago

Thanks! Published 0.18.1