search

microsoft / mdatp-xplat

Microsoft Defender for macOS/Linux - config samples, auxiliary tools
MIT License
187 stars 188 forks source link

changing apt-key method of adding key by gpg --dearmor #143

Open anoliveiraM opened 1 month ago

anoliveiraM commented 1 month ago

since ap-key has been deprecated:

Manpages Evidence

https://manpages.debian.org/testing/apt/aptkey.8.en.html#:~:text=Use%20of%20apt,and%20Ubuntu%2022.04.

Debian Release Notes

https://www.debian.org/releases/bullseye/amd64/release-notes/ch-information.en.html#deprecated-components:~:text=bullseye%20is%20the%20final%20Debian%20release%20to%20ship%20apt%2Dkey.%20Keys%20should%20be%20managed%20by%20dropping%20files%20into%20/etc/apt/trusted.gpg.d%20instead%2C%20in%20binary%20format%20as%20created%20by%20gpg%20%2D%2Dexport%20with%20a%20.gpg%20extension%2C%20or%20ASCII%20armored%20with%20a%20.asc%20extension.

So we should not be using apt-key we already have some support cases running into this issue.

okopel commented 1 month ago
  1. Please update version
  2. Does this change have Backward compatibility?
anoliveiraM commented 1 month ago

@okopel , just changed the script version also in terms of compatibility since we are checking and installing gnupg and using it it should be backwards compatible on their docs there's nothing that would not indicate so: https://www.gnupg.org/download/supported_systems.html

The current method we have in the code will fail with most recent OSs :(