microsoft / mggraph-intune-samples

Repository to hold Microsoft Intune script samples for the Microsoft Graph PowerShell SDK
https://learn.microsoft.com/en-us/graph/api/resources/intune-graph-overview
MIT License
131 stars 30 forks source link

Add Win32_LOB_App.ps1 sample file #16

Closed Daigle-ISM closed 1 month ago

Daigle-ISM commented 1 month ago

Add a sample file for uploading a Win32_LOB application using MSAL, similar to iOS_Application_LOB_App.ps1 and the old microsoftgraph/powershell-intune-samples/blob/master/LOB_Application/Win32_Application_Add.ps1

File includes comment help blocks with examples

Daigle-ISM commented 1 month ago

@microsoft-github-policy-service agree company="ISM"

Mahopper commented 1 month ago

Thanks for the contribution @Daigle-ISM. Timing is interesting on this one- I just finished the updated sample and documentation which contains a handful of reworks on Win32_Application_Add.ps1 here: https://github.com/microsoft/mggraph-intune-samples/pull/17

We'll take a look at the sample you provided, and see if we can merge any of your changes/methods to the script in https://github.com/microsoft/mggraph-intune-samples/pull/17. Thanks again.

Daigle-ISM commented 1 month ago

Thanks for the contribution @Daigle-ISM. Timing is interesting on this one- I just finished the updated sample and documentation which contains a handful of reworks on Win32_Application_Add.ps1 here: #17

We'll take a look at the sample you provided, and see if we can merge any of your changes/methods to the script in #17. Thanks again.

Oh that's a bit unfortunate, but I appreciate your work on this. I would be surprised if there was anything in my sample that you haven't already covered (besides some style choices and small things like #requires instead of import-module), let me know if you have questions/need anything

Mahopper commented 1 month ago

@Daigle-ISM Sure thing- I've added your suggestion to use #requires instead of import-module. Going to close this out for now- thanks again for the submission.