search

microsoft / microcode

Coding "on the go" with the micro:bit (V2)
https://microsoft.github.io/microcode
MIT License
47 stars 18 forks source link

loading save slots crashes on hardware #427

Closed pelikhan closed 11 months ago

pelikhan commented 11 months ago
pelikhan commented 11 months ago

The save slot are containing programs with the old format; we should swallow deserialization issues.

tballmsft commented 11 months ago

this is not a huge issue. people will start with fresh hex files, for the most part. I don't really think it is worth keeping the old JSON format alive, do you?

pelikhan commented 11 months ago

We should not crash.

From: Tom Ball @.> Sent: Sunday, October 15, 2023 8:53:46 PM To: microsoft/microcode @.> Cc: Author @.>; Comment @.>; Subscribed @.***> Subject: Re: [microsoft/microcode] loading save slots crashes on hardware (Issue #427)

this is not a huge issue. people will start with fresh hex files, for the most part. I don't really think it is worth keeping the old JSON format alive, do you?

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/microcode/issues/427#issuecomment-1763684490 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA73QKP2R4LONY2C2MIY7I3X7SVUVBFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDMNBZGU3DMMBUGSSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44TQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJTGI4DOMZSG4YDNAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDCOJUGQZDAMJXGAYIFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIZDMNBZGU3DMMBUGSTXI4TJM5TWK4VGMNZGKYLUMU. You are receiving this email because you authored the thread.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

tballmsft commented 11 months ago

https://github.com/microsoft/microcode/commit/0bc0fefd4aae37a5a7d47604db48f6743c07fe80