search

microsoft / microsoft-ui-xaml

WinUI: a modern UI framework with a rich set of controls and styles to build dynamic and high-performing Windows applications.
MIT License
6.38k stars 683 forks source link

Proposal: Get rid of uneven left/right spacing on MenuFlyout #1445

Closed chigy closed 5 years ago

chigy commented 5 years ago

We noticed this with #1079 which was pointing out the space on Top/Bottom which is by design.

However, during the conversion, design and I noticed the gap on left/right and further noticed that they don't seem to be even on both sides... We would like this gap to be removed and the hover state to go edge to edge.

image

shaheedmalik commented 5 years ago

I agree. The way it currently is, the hover isn't even centered.

It should all the way across.

jevansaks commented 5 years ago

@chigy does this need to be a feature proposal? Seems like we should just fix it as a bug?

marcelwgn commented 5 years ago

If this is a bug I would be happy to take my shot at it. 😃

chigy commented 5 years ago

@jevansaks , I debated if I should open a bug but technically, this is a design change request so I opened a feature proposal. No problem with that being handled as a bug.

adrientetar commented 5 years ago

Also, when opening a submenu, shouldn't the item text vertically align with base menu text? Seems like the padding at the top isn't accounted for currently.

chigy commented 5 years ago

@adrientetar , good eyes! We were about to open a request to fix that. The select visual should be aligned. Would you do me an honor if you don't mind? (Ignore the vertical circle)

image

mdtauk commented 5 years ago

@chigy, looking at the image image

Shouldn't the sub menu be casting a shadow on the lower menu? At the moment they blend together

adrientetar commented 5 years ago

Would you do me an honor if you don't mind?

Huh, are you asking me to open an issue about it? See #1462

Shouldn't the sub menu be casting a shadow on the lower menu? At the moment they blend together

Yeah, I'd say go ahead and open a design bug

chigy commented 5 years ago

@adrientetar , thanks for the design bug!

chigy commented 5 years ago

Shouldn't the sub menu be casting a shadow on the lower menu? At the moment they blend together

Please feel free to open design bug. This could have been a shadow limitation but we should document it nonetheless...

chigy commented 5 years ago

Shouldn't the sub menu be casting a shadow on the lower menu? At the moment they blend together

Please feel free to open design bug. This could have been a shadow limitation but we should document it nonetheless...

@adrientetar , I confirmed this is a technical limitation that we cannot draw shadow on shell popups's sub-menus.

adrientetar commented 5 years ago

@chigy, could we have an updated design toolkit? here: https://docs.microsoft.com/en-us/windows/uwp/design/downloads/

chigy commented 5 years ago

@chigy, could we have an updated design toolkit? here: https://docs.microsoft.com/en-us/windows/uwp/design/downloads/

@adrientetar , we are currently working on it with update for WinUI2.2.

mdtauk commented 5 years ago

Would be good if UI Toolkits were released at the same time as a WinUI version in the future. Maybe formally tie the two together.

chigy commented 5 years ago

Would be good if UI Toolkits were released at the same time as a WinUI version in the future. Maybe formally tie the two together.

@mdtauk , I understand, I'd like that also. We are doing what we can.