microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.3k stars 675 forks source link

TabView: Change TabStripFooter's MinWidth when app started with a narrow window is not take effect #1615

Closed yanshouwang closed 1 year ago

yanshouwang commented 4 years ago

Describe the bug After extend TabView into the title bar, we need to change the TabStripFooter's MinWidth to keep off the title bar buttons. But change TabStripFooter's MinWidth when app started with a narrow window is not take effect

Steps to reproduce the bug Steps to reproduce the behavior:

  1. Extend the TabView into the TitleBar, and change the TabStripFooter's MinWidth when "OnTitleBarLayoutMetricsChanged" event is invoked.
  2. Add 3 or more tabitems in the TabView.
  3. Close the app with a narrow window state.
  4. Open the app with the narrow window, the OnTitleBarLayoutMetricsChanged is invoked and the TabStripFooter's MinWidth is changed, but the TabView still mixed with the TitleBar's buttons until drag the window to a wide state.

Expected behavior TabView shoud keep away from the TitleBar's buttons.

Screenshots 批注 2019-11-15 000540 批注 2019-11-15 000428 批注 2019-11-15 000350

Version Info

NuGet package version: Microsoft.UI.Xaml 2.2.190917002

Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2019 Update (18362) Yes
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT

Additional context

YuliKl commented 4 years ago

@teaP can you take a look?

marcelwgn commented 3 years ago

@teaP Are you looking into this issue right now? If not, can I look into this issue? @StephenLPeters FYI.

marcelwgn commented 3 years ago

@ranjeshj @teaP Is this safe to work on? This bug has also caused issues in the XCG for quite some time now. It seems that changing the width/minwidth property of the footer is being ignored by the calculation of the width tabstrip resulting in it to occupy more space than it should have.

ranjeshj commented 3 years ago

@chingucoding go for it.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.