microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.32k stars 676 forks source link

Discussion: Update Reveal control styles to work with the Visual Design refresh #4064

Open mdtauk opened 3 years ago

mdtauk commented 3 years ago

Proposal: Update Reveal control styles to work with the Visual Design refresh

Light - Buttons Light - Buttons

Light - SplitButtons Light - SplitButtons

Light - Accent Button Light - Accent Button


Dark - Buttons Dark - Buttons

Dark - SplitButtons Dark - SplitButtons

Dark - Accent Button Dark - Accent Button

Summary

Whilst Reveal is no longer being used by default, the feature is not going away - so the Reveal control styles should be updated to work with the new control styles.

I would suggest the Highlight should be hidden, the control borders should still display the Reveal effect

Rationale

visual inconsistencies with Reveal currently Visual inconsistencies with Reveal currently

Scope

Capability Priority
All existing Reveal control styles should update to match the updated visual styles Should
The spotlight effect could be ommitted to focus on the borders as your cursor approaches the control Could
Reveal styles will still be removed by default for all controls hosting controls Won't

Important Notes

This will ensure all controls will sit together comfortably, with or without Reveal.

Open Questions

shaheedmalik commented 3 years ago

If reveal was reworked in this manner, then it should be default. The only reason why it was removed as default is because it was broken.

mdtauk commented 3 years ago

If reveal was reworked in this manner, then it should be default. The only reason why it was removed as default is because it was broken.

It won't work day one with WinUI 3, but it's not broken, the design team just don't think it is effective for their visual style goals, and now controls have borders and spacing between items, no longer looks clean and elegant.

But if someone's app has the reveal styles on their controls, it's going to look inconsistent with the new control designs.

Better to update the styles that apply reveal, and choose to not use them with Microsoft's own control defaults, shell designs, and apps.

mdtauk commented 3 years ago

Here are some more examples, again with no spotlight on the background plates, but overlaying the reveal border on the control's border or around the backplate

Light Mode Reveal Styles Light Mode Reveal Styles

Dark Mode Reveal Styles Dark Mode Reveal Styles

jordan-msftfan commented 3 years ago

We have to admit that some people like Reveal and some people don't.

I agree with the first sentence to some extent but not entirely.

  1. Reveal should be default.

  2. Reveal should have integrated a switch into the system's Settings app once it was implemented in WinUI 3.

chigy commented 3 years ago

@mdtauk , thank you for your thoughtful proposal. Discussed with design team about your proposal and I confirmed that reveal is not our current or near future design language and principles as I had indicated in a separate reveal related item. While we can never say it will never come back, but it is not realistic to believe it will in the near future, thus I'm turning this item into discussion.

mdtauk commented 3 years ago

@mdtauk , thank you for your thoughtful proposal. Discussed with design team about your proposal and I confirmed that reveal is not our current or near future design language and principles as I had indicated in a separate reveal related item. While we can never say it will never come back, but it is not realistic to believe it will in the near future, thus I'm turning this item into discussion.

The proposal is not about retaining Reveal as part of the design language, but to consider what not updating the existing Reveal styles will do for apps which are currently using them. Those buttons for instance will look like the WinUI 2.5 ones, alongside the new Latest Button designs.

By all means take away the Reveal Styling from controls like the Application Bar or Navigation View by default - but there are control styles for Reveal included, and these should be updated.

My proposal is just about demonstrating how the styles can be adapted to work with the new styles.

Shomnipotence commented 3 years ago

@mdtauk , thank you for your thoughtful proposal. Discussed with design team about your proposal and I confirmed that reveal is not our current or near future design language and principles as I had indicated in a separate reveal related item. While we can never say it will never come back, but it is not realistic to believe it will in the near future, thus I'm turning this item into discussion.

Ask you, does the design team think acrylic is still needed? Although this is not the goal of WinUI31.0, I just want to know whether acrylic is still one of the important languages for design.