search

microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.31k stars 676 forks source link

Modern title bar context menu #4769

Open JaiganeshKumaran opened 3 years ago

JaiganeshKumaran commented 3 years ago

Today WinUI desktop uses the old title bar context menu which is used in UWP apps and old Win32 apps while the tooltip is modern. This weird combination should be eliminated and the context menu should be a modern XAML one

JaiganeshKumaran commented 3 years ago

Also the height of the custom "title bar icons" when the title bar is extended is very small compared to modern Windows apps making it inconsistent and not that touch friendly. I think the size should be same as most modern apps

billhenn commented 3 years ago

In addition to making the context menu not look Win32 by default, it would be great to also have options to fully customize the title bar context menu too with custom menu items.

StephenLPeters commented 3 years ago

@pratikone and @Austin-Lamb FYI

sylveon commented 3 years ago

The Win32 context menu can already be customized, by calling the GetSystemMenu API and then using APIs like InsertMenuItem and RemoveMenu.

sylveon commented 3 years ago

But yes, a modern context menu would be nice and I've already achieved it in my xaml islands implementation. It's actually one of the reasons I'm staying on xaml islands for now (besides the obvious fact winui 3 won't support islands at launch)

Related: https://github.com/microsoft/ProjectReunion/issues/95

pratikone commented 3 years ago

@marb2000 on these suggestions

JaiganeshKumaran commented 3 years ago

Another thing is that the current title bar looks white even in dark mode. While you can extend to title bar and draw a custom one, I expect the default one to be dark in dark mode. There's an undocumented way to get the default Win32 title bar to be dark in dark mode which WinUI 3 could apply.

shaheedmalik commented 3 years ago

Another thing is that the current title bar looks white even in dark mode. While you can extend to title bar and draw a custom one, I expect the default one to be dark in dark mode. There's an undocumented way to get the default Win32 title bar to be dark in dark mode which WinUI 3 could apply.

That particular context menu is handled by the Window's Shell team. It's on them to fix it.

sylveon commented 3 years ago

Apps can have special handling and show a custom context menu here. WinUI 3 doesn't need to wait on the shell team.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

mdtauk commented 1 year ago

There is still an argument for using - by default - a modern style context menu, instead of the Win32 one. Especially with Xaml Windows and when Extending into the Title Bar area... image

pratikone commented 1 year ago

Marking it as a feature request for better tracking