microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.36k stars 678 forks source link

Broken TabItemTemplateSelector in both WinUI 3 Desktop and UWP with WinUI 2.6.2 #5852

Closed harvinders closed 1 year ago

harvinders commented 3 years ago

Describe the bug

Using TabItemTemplateSelector to display a collection as TabViewItem does not display TabItems properly.

Steps to reproduce the bug Simply add TabItemTemplateSelector and bind TabItemsSource to an ObservableCollection

Also, see the repo at here

Expected behavior

Screenshots

WinUI 3 0.8.2 image

WinUI 2.6.2 (UWP) image

Version Info

NuGet package version:

[Microsoft.UI.Xaml 2.6.2] [WinUI 3 - Windows App SDK 0.8: 0.8.2]

Windows app type: UWP Win32
Yes Yes
Windows version Saw the problem?
Insider Build (xxxxx)
May 2021 Update (19043)
October 2020 Update (19042)
May 2020 Update (19041)
November 2019 Update (18363) Yes
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context

StephenLPeters commented 3 years ago

@beervoley or @chingucoding do you know whats going on here?

blake-fm commented 2 years ago

Was able to reproduce this using WinAppSDK 1.0.0 stable on Win11 -- new Win32 app, add TabView, use a TemplateSelector.

Also created a dirty, dirty workaround. Should be a quick copy/pasta to back out, when the resolved issue makes it to us. In case it helps anyone:

https://stackoverflow.com/a/70821759/17972737

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.