search

microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.27k stars 674 forks source link

BorderThickness and BorderBrush properties of ListViewItem are not working when setting CornerRadius for items in ListView control. #6595

Open SubashiniMahendran opened 2 years ago

SubashiniMahendran commented 2 years ago

Describe the bug

I have tried to set the CornerRadius for items in ListView control as 4. If I set CornerRadius property in ListViewItemPresenter, BorderThickness and BorderBrush properties of ListViewItem are not working. please find the demo regarding it below:

Demo: ListView-issue.zip

Steps to reproduce the bug

  1. Run the sample.
  2. Note, Border was not shown in list view items when setting CornerRadius.

Expected behavior

Border should be shown in list view items when setting CornerRadius.

Screenshots

image

image

NuGet package version

WinUI 3 - Windows App SDK 1.0 (If you're seeing your issue in older previews of WinUI 3, please try this release)

Windows app type

Device form factor

Desktop

Windows version

October 2020 Update (19042)

Additional context

If we removed the corner radius set in style, then border was shown.

image

image

bogdan-patraucean commented 2 years ago

I noticed the same problem.

StephenLPeters commented 2 years ago

@RBrid I think we would have noticed this in Winui2 if it was a controls problem.. no? @gegao18 and @codendone is this behavior in winui3 understood? is the corner radius clip removing the border?

pluto-dev commented 1 year ago

@StephenLPeters I've encountered the same issue but for WinUI2

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

bogdan-patraucean commented 1 year ago

Up

mdtauk commented 1 year ago

The ListViewItemPresenter does not bind every possible value, as border brushes are missing.

ghord commented 1 year ago

@mdtauk The issue is that ListViewItemPresenter ignores any value for BorderThickness, even if you set it manually in ControlTemplate of ListViewItem.

mdtauk commented 1 year ago

@mdtauk The issue is that ListViewItemPresenter ignores any value for BorderThickness, even if you set it manually in ControlTemplate of ListViewItem.

I think the ControlTemplate for the Presenter is embedded in the OS, and so doesn't work for re-templating properly

pluto-dev commented 1 year ago

That's the issue, we have to guess. Is it intended, is it a bug, or something else.

Prem-Kumar-Shanmugam commented 9 months ago

is it fixed ?? need to be fixed soon