search

microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.27k stars 674 forks source link

ColorPicker More/Less button has incorrect a11y help text #7395

Open carlos-zamora opened 2 years ago

carlos-zamora commented 2 years ago

Describe the bug

See https://github.com/microsoft/terminal/issues/12046

The help text for the More/Less button is currently: "Invoke to show or hide the text entry fields."

When "More" is shown, it should be "Invoke to show the text entry fields.". When "Less" is shown, it should be "Invoke to hide the text entry fields.".

Basically, it should be more specific.

Steps to reproduce the bug

  1. In WinUI2 Gallery, go to: winui2gallery://item/ColorPicker
  2. Ensure IsMoreButtonVisible is enabled
  3. (While using a screen reader), tab to the "More" or "Less" button

Expected behavior

For 'More' button Screen Reader should announce 'More button, invoke to show the text entry fields' and for 'Less' button Screen Reader should announce 'Less button, invoke to hide the text entry fields'

Screenshots

No response

NuGet package version

No response

Windows app type

Device form factor

Desktop

Windows version

No response

Additional context

WinUI 2 Gallery version: 1.2.25.0

zadjii-msft commented 2 years ago

(Internal bug: MSFT:40517763)

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

zadjii-msft commented 1 year ago

This is still an issue.