microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.35k stars 677 forks source link

Proposal: Dialog Smoke Update #840

Open sravya03 opened 5 years ago

sravya03 commented 5 years ago

Proposal: Update Dialog's smoke layer to be always black based color

Summary

Windows design evaluated the color of light theme's smoke layer (it is white). It is a little harsh on eyes and also goes against the wish to make the light theme less "white" (per user feedback). The white background also make the app look like it is hang (Win32 app model). Fabric also uses this model where their smoke is smoke (instead of a fog).

Rationale

Addressing problems that exist today, such as:

Scope

Capability Priority
Developers are able to use WinUI2.2* package and without any work, get the new Windows visual style. Must
Developers and end users experience control update that feel coherent with the same controls used by Fabric, Edge, and Xbox. Should

*Timing here is not a commitment, but to follow the release cycle. Just using the next version #.

Design details and visuals

This impacts only ContentDialog Visual Comp

New values to use:

000000 at 30% opacity for both dark/light theme

Important Notes

Open Questions

mdtauk commented 5 years ago

807 Ensure that the elevation shadows are still visible on the darker background. Fading to lighter colour does feel unresponsive

chigy commented 5 years ago

807 Ensure that the elevation shadows are still visible on the darker background. Fading to lighter colour does feel unresponsive

@mdtauk , it is still visible but might be less noticeable. It is OK, though, because the smoke is another method for indicating depth.

chigy commented 5 years ago

Status update: Reviewed with WinUI team and there was no immediate concern with the design's plan here. (Waiting for updated smoke color from design team.)

chigy commented 5 years ago

Status update:

Updated color value was provided by the design team.

000000 at 30% opacity for both dark/light theme