microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.33k stars 675 forks source link

Menubar breaks cross platform menubar behavior conventions #8953

Open Permik opened 1 year ago

Permik commented 1 year ago

Which version of the app?

WinUI 2 Gallery, WinUI 3 Gallery

Description

Across different platforms you can operate menubars and dropdowns using a "drag-click" that is initiated by pressing down the primary mouse key over the button, keeping the primary mouse key pressed while going through the menus and releasing over the currently hovered/drag-clicked/selected action to activate it.[^1]

To boil it down, the steps below doesn't work anymore. This used to work with win32 top level menu items, but the behavior has regressed.

Steps to Reproduce

  1. Press down on your mouse on a top level menu item (File, Edit, View, Help)
  2. Keep holding down the mouse button
  3. The top level menu opens
  4. You move the cursor over the menu item you want to activate
  5. You release the mouse button

Examples of dropdowns and menubars supporting drag clicking:

Yes, this regression also applies to the ComboBox element also, but I'll wait for feedback on this before making an another issue about that.

[^1]: Aside: This behavior works across OS's and is a delightful behavior that feels really good when it's implemented. Something about not needing to click a second time to act on a dropdown that I personally find really satisfying. This also gives the powerusers the ability to "flick" really fast through visual menus because of reducing the need to stop to click something.

Screenshots

No response

Windows version

Insider Build (xxxxx)

Additional context

Version 23H2 OS Build (25967.1000) WinUI3 Gallery Version: 2.2.0.0 WinUI2 Gallery Version: 1.2.26.0

For context the original report in WinUI gallery repo if this is deemed invalid here: https://github.com/microsoft/WinUI-Gallery/issues/1372

fdwr commented 5 months ago

Yes! Efficient useability matters, and this bug is annoying in all the extra left clicks it adds during my day (which already average 4000+). I opened Feedback issue on Win11's Notepad today for this functionality regression, which Kenny G pointed to WinUI3 as the culprit. Please fix.