MenuFlyoutItem icon's foreground doesn't change back to resting color

microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications

MIT License

6.27k stars 674 forks source link

MenuFlyoutItem icon's foreground doesn't change back to resting color #9690

Open eduardobragaxz opened 3 months ago

eduardobragaxz commented 3 months ago

Describe the bug

If you change the foreground of a MenuFlyoutItem and then hover over it, the color won't return for the icon once the pointer goes away.

Steps to reproduce the bug

Create a project with a MenuFlyoutItem and change it's foreground.

Expected behavior

No response

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.5.3: 1.5.240428000

Windows version

Windows 11 (22H2): Build 22621

Additional context

No response

github-actions[bot] commented 3 months ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Open similar issues:

MenuFlyoutItem text doesn't sync with system theme. (#8678), similarity score: 0.78

Closed similar issues:

Setting Foreground on MenuBarItem doesn't work (#7070), similarity score: 0.79
MenuFlyout does not update correctly on theme change (#8077), similarity score: 0.78
WinUI3 Button XAML Template does not respect Foreground property after mouse passes over (#7208), similarity score: 0.78
Customized title caption buttons not retaining inactive styling (#8228), similarity score: 0.78

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

codendone commented 3 months ago

How are you changing the foreground on the MenuFlyoutItem? If you set the Foreground property directly on the element, this will override any values being set from style.

eduardobragaxz commented 3 months ago

Yeah I just change the Foreground on the MenuFlyoutItem. If I hover the mouse the text and icon will change to white/black, and when I move the mouse away only the text reverts to the color I set. The icon remains white/black.

eduardobragaxz commented 3 months ago

https://github.com/microsoft/microsoft-ui-xaml/assets/50815710/a6a1982c-794d-43b5-a732-c02bd8829b03

You can see the very fist AppBarButton that is blue works correctly, but the two MenuFlyoutItems don't.

codendone commented 2 months ago

Thanks for clarifying!

kmahone commented 1 month ago

I think this is a similar root cause to #7208.

In the default template, the TextBlock has Foreground="{TemplateBinding Foreground}", however the ContentPresenter for the Icon has no Foreground set. So when transitioning away from the PointerOver state, the icon foreground does not revert back to what it was previously.