microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.31k stars 676 forks source link

Visual Studio Publish command ignores timestamp server setting #9779

Open vsfeedback opened 3 months ago

vsfeedback commented 3 months ago

This issue has been moved from a ticket on Developer Community.


[severity:It's more difficult to complete my work] When using VS 2022 version 17.7.3 to publish a .NET app, if you provide a timestamp server along with your private signing certificate, the command will sign the resultant MSIX file, but will leave it unstamped.

Steps to reproduce:

  1. Create a new project based on the .NET MAUI Blazor template, open the project in VS 2022;
  2. Select the Release configuration;
  3. RIght-click on the project in the solution tree, choose Publish;
  4. Choose the side-loading option;
  5. On the Select signing method page, choose a certificate from a local certificate store (we use our own EV signing certificate for that);
  6. On the same page provide timestamp server URL (for example, http://timestamp.digicert.com)
  7. On the same page select Signing algorithm SHA256;
  8. On the next page, create a new publishing profile;
  9. Wait for the Publish command to complete.

Check the MSIX file it produced (such as \bin\Release\net7.0-windows10.0.19041.0\win10-x64\AppPackages\BlazorMauiApp1_1.0.0.0_Test\BlazorMauiApp1_1.0.0.0_x64.msix): it would be signed, but not time-stamped.


Original Comments

Feedback Bot on 9/13/2023, 06:57 PM:

(private comment, text removed)

Zack Yang [MSFT] on 9/14/2023, 08:21 PM:

(private comment, text removed)

Andrei Belogortseff on 9/15/2023, 06:19 AM:

(private comment, text removed)

Andrei Belogortseff on 9/18/2023, 05:36 PM:

(private comment, text removed)

Zack Yang [MSFT] on 9/18/2023, 10:52 PM:

(private comment, text removed)

Feedback Bot on 9/18/2023, 10:52 PM:

(private comment, text removed)

Feedback Bot on 9/19/2023, 09:37 AM:

(private comment, text removed)

Feedback Bot on 12/28/2023, 00:49 AM:

(private comment, text removed)

Kirwan Smith on 6/30/2024, 03:50 PM:

(private comment, text removed)

Zack Yang [MSFT] on 6/30/2024, 07:57 PM:

(private comment, text removed)


Original Solutions

(no solutions)

MSLukeWest commented 3 months ago

In the UWP and Wapproj scenarios setting the two options shown below will result in these values getting used during package signing. But the WinAppSDK build targets ignore these values. They should be updated to use these two MSBuild properties when they're set:

image

DominikErnst commented 2 months ago

Same here. Please fix!