microsoft / microsoft-ui-xaml

Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications
MIT License
6.35k stars 678 forks source link

Proposal: official support of UISettings.ColorValuesChanged #9897

Open fabianoriccardi opened 2 months ago

fabianoriccardi commented 2 months ago

Proposal: official support of UISettings.ColorValuesChanged

Summary

Currently the API UISettings.ColorValuesChanged works only for specific configurations, but in general it is not supported (docs). It would be great having the support for the developers of Windows App SDK and MAUI.

Rationale

1) The feature should be added to ease the developers and to avoid the "tricks" proposed in #9372. 2) UISettings.ColorValuesChanged was introduced with UWP, so it will ease the migration from UWP to new frameworks.

Scope

Capability Priority
This proposal will allow developers to use ColorValuesChanged as they were used to in UWP Must
jschroedl commented 2 months ago

Came here to add my vote as someone working on a classic Desktop Win32 app written with C++. No WinUI 3 involved for me. I want to call a C++/WinRT API to register for an event which will let me know when the theme has changed between Light/Dark. It's a tragedy that this requires tricks today. I need to support Win10 and Win11.

What's most vexing is that this article indicates I should use the ColorValuesChanged event for Win32 apps: Support Dark and Light themes in Win32 apps

While this document indicates that the event is unsupported for Desktop apps. Any guidance on which is correct? Windows Runtime APIs not supported in desktop apps