microsoft / mimalloc

mimalloc is a compact general purpose allocator with excellent performance.
MIT License
10.45k stars 843 forks source link

error: 'large_os_page_size' undeclared #802

Open mtelka opened 1 year ago

mtelka commented 1 year ago

Compilation on illumos (Solaris clone) fails:

warning: In file included from c_src/mimalloc/src/prim/prim.c:22,
warning:                  from c_src/mimalloc/src/static.c:37:
warning: c_src/mimalloc/src/prim/unix/prim.c: In function 'unix_mmap':
warning: c_src/mimalloc/src/prim/unix/prim.c:313:28: error: 'large_os_page_size' undeclared (first use in this function); did you mean '_mi_os_page_size'?
warning:   313 |         cmd.mha_pagesize = large_os_page_size;
warning:       |                            ^~~~~~~~~~~~~~~~~~
warning:       |                            _mi_os_page_size
warning: c_src/mimalloc/src/prim/unix/prim.c:313:28: note: each undeclared identifier is reported only once for each function it appears in
devnexen commented 1 year ago

Would the PR's branch work for you ?

kulikjak commented 11 months ago

Hi, not the original reporter, but I've also hit this issue on Solaris (Oracle), and the fix works in our case.

I've hit/tested it in Python 3.13, but I don't see how it would be different here.