search

microsoft / mimalloc

mimalloc is a compact general purpose allocator with excellent performance.
MIT License
10.45k stars 843 forks source link

fix illumos build #841

Closed dancrossnyc closed 7 months ago

dancrossnyc commented 8 months ago

In 08a01d26dc079756c8e94409fba051fd2eb5bd2c, the primitive layer changed and the large_os_page_size static was replaced by the _mi_os_large_page_size function. However, an #elif predicated by __sun that referred to large_os_page_size was missed in that change. This simply changes that reference to the function.

dancrossnyc commented 8 months ago

@daanx may I please request your review here?

daanx commented 7 months ago

Thanks! I pushed a fix to dev (for now, dev-slice will be merged soon). I redid your PR as you based on master but included credit.

dancrossnyc commented 7 months ago

Thanks!

mtelka commented 6 months ago

Thanks for the fix! When we can expect to see it in a release?

daanx commented 6 months ago

ah, real soon. (I am currently preparing and if tests go well I hope to release on Tuesday)