search

microsoft / mimalloc

mimalloc is a compact general purpose allocator with excellent performance.
MIT License
9.74k stars 791 forks source link

2.1.4 and error mingw/msys2 #884

Closed 3rav closed 1 month ago

3rav commented 2 months ago

I have this error with 2.1.4 (2.1.2 was OK)

 -- Library base name: mimalloc
  -- Version          : 2.1
  -- Build type       : release
  -- C Compiler       : D:/M/msys64/mingw64/bin/gcc.exe
  -- Compiler flags   : -Wall;-Wextra;-Wno-unknown-pragmas;-fvisibility=hidden;-Wstrict-prototypes;-ftls-model=initial-exec;-fno-builtin-malloc
  -- Compiler defines : 
  -- Link libraries   : psapi;shell32;user32;advapi32;bcrypt
  -- Build targets    : shared;static
  -- 
  -- Configuring done (0.9s)
  -- Generating done (0.0s)
  -- Build files have been written to: C:/_/B/src/build-MINGW64
  ninja: error: 'C:/_/B/src/mimalloc-2.1.4/bin/mimalloc-redirect.lib', needed by 'libmimalloc.dll', missing and no known rule to make it
  ==> ERROR: A failure occurred in build().
      Aborting...
  ==> Removing installed dependencies...
  checking dependencies...
daanx commented 2 months ago

ah, that is strange -- I don't think anything changed here with cmake? Maybe try to use make instead of ninja to build?

AlifianK commented 2 months ago

v2.1.4 tag doesn't contain bin folder, which is present in v2.1.2. If you look in the bin folder, you'll see that it contains the required .lib file. @daanx perhaps you forget to include that?

Further clarifying what I said, the tag I mentioned is from Github Releases, not the git branch. The git branch still contains bin folder.

daanx commented 1 month ago

Mmm, very strange -- maybe a merge error. Thanks for reporting this, I'll fix it with the release update later this week.

daanx commented 1 month ago

This is fixed now with v2.1.7. (it was an error in the .gitattributes)