Emscripten: Remove no-longer-needed minimum emmalloc alignment

microsoft / mimalloc

mimalloc is a compact general purpose allocator with excellent performance.

MIT License

9.74k stars 791 forks source link

Emscripten: Remove no-longer-needed minimum emmalloc alignment #891

Closed kripken closed 1 month ago

kripken commented 1 month ago

https://github.com/emscripten-core/emscripten/pull/20704 removed the maximum alignment limit from emmalloc, so we no longer need it in the mimalloc port. Without it, we can properly use the 4GB-aligned pages that mimalloc requests.

(Emscripten-side testing in https://github.com/emscripten-core/emscripten/pull/21905)

daanx commented 1 month ago

Ah, this is great. The previous approach lead to mimalloc always re-requesting with overallocation so this is much better.